application-manager: pull newer version of Webpack #9831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue when bundling Theia applications in production as of `[email protected]`, so we can revert `webpack`'s range to pull newer versions again.
vince-fugnitto
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
I confirmed that:
- the updated dependency is license compatible.
-
productionbuilds still work correctly, meaning the fix towebpack-sourcesis valid.
gitpod /workspace/theia $ yarn why webpack
yarn why v1.22.10
[1/4] Why do we have the module "webpack"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "[email protected]"
info Reasons this module exists
- "_project_#@theia#application-manager" depends on it
- Hoisted from "_project_#@theia#application-manager#webpack"
info Disk size without dependencies: "6.25MB"
info Disk size with unique dependencies: "6.25MB"
info Disk size with transitive dependencies: "6.25MB"
info Number of shared dependencies: 46
Done in 1.17s.
gitpod /workspace/theia $ yarn why webpack-sources
yarn why v1.22.10
[1/4] Why do we have the module "webpack-sources"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "[email protected]"
info Reasons this module exists
- "_project_#@theia#application-manager#@theia#compression-webpack-plugin" depends on it
- Hoisted from "_project_#@theia#application-manager#@theia#compression-webpack-plugin#webpack-sources"
info Disk size without dependencies: "80KB"
info Disk size with unique dependencies: "968KB"
info Disk size with transitive dependencies: "968KB"
info Number of shared dependencies: 2
=> Found "webpack#[email protected]"
info This module exists because "_project_#@theia#application-manager#webpack" depends on it.
info Disk size without dependencies: "156KB"
info Disk size with unique dependencies: "156KB"
info Disk size with transitive dependencies: "156KB"
info Number of shared dependencies: 0
Done in 0.95s.
msujew
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue when bundling Theia applications in production as of
[email protected], so we can revertwebpack's range to pullnewer versions again.
How to test
yarn && yarn --cwd examples\browser theia buildshould work.yarn why webpack-sourcesshould output something equal or greater to 3.2.0.Review checklist
Reminder for reviewers